Introduce ImmutableEnumSetRules Refaster rule collection
#1302
Conversation
|
|
Looks good. No mutations were possible for these changes. |
There was a problem hiding this comment.
Mostly some tweaks to Refaster rule names. Nice new collection @mohamedsamehsalah 🚀!
Added a commit.
Suggested commit message:
Introduce `ImmutableEnumSetRules` Refaster rule collection (#1302)
| * Prefer {@link Sets#immutableEnumSet(Iterable)} for enum collections to take advantage of | ||
| * internally used {@link EnumSet}. | ||
| */ | ||
| static final class ImmutableEnumSetIterable<T extends Enum<T>> { |
There was a problem hiding this comment.
The yet-to-be formalized Refaster naming algorithm would add the Sets here in front :).
| */ | ||
| static final class ImmutableEnumSetIterable<T extends Enum<T>> { | ||
| @BeforeTemplate | ||
| ImmutableSet<T> before(Collection<T> elements) { |
There was a problem hiding this comment.
Based on the name wanted to change this to an Iterable, but that doesn't work here, the copyOf expects a Collection.
There was a problem hiding this comment.
Eh, there's an Iterable-accepting overload. Just means we need to cover both cases.
| } | ||
|
|
||
| ImmutableSet<ImmutableSet<RoundingMode>> testImmutableEnumSetIterable() { | ||
| return ImmutableSet.of( |
There was a problem hiding this comment.
I think we can simplify the first two tests to simply have one test case :).
| RoundingMode.UNNECESSARY))); | ||
| } | ||
|
|
||
| ImmutableSet<RoundingMode> testImmutableEnumSetSixElements() { |
There was a problem hiding this comment.
For other similar rules we stopped at 5, but because its already here, might as well leave it in 😉.
rickie
force-pushed
the
mohamedsamehsalah/immutable-enum-set
branch
from
8d0eeb7 to
e80ef1d
Compare
|
Looks good. No mutations were possible for these changes. |
1 similar comment
|
Looks good. No mutations were possible for these changes. |
Stephan202
force-pushed
the
mohamedsamehsalah/immutable-enum-set
branch
from
e80ef1d to
81bf53e
Compare
| */ | ||
| static final class ImmutableEnumSetIterable<T extends Enum<T>> { | ||
| @BeforeTemplate | ||
| ImmutableSet<T> before(Collection<T> elements) { |
There was a problem hiding this comment.
Eh, there's an Iterable-accepting overload. Just means we need to cover both cases.
| } | ||
|
|
||
| ImmutableSet<RoundingMode> testSetsImmutableEnumSetIterable() { | ||
| return Sets.immutableEnumSet(EnumSet.range(RoundingMode.UP, RoundingMode.UNNECESSARY)); |
There was a problem hiding this comment.
We can use the shorter EnumSet.allOf(RoundingMode.class) here.
| * Prefer {@link Sets#immutableEnumSet(Iterable)} for enum collections to take advantage of the | ||
| * internally used {@link EnumSet}. | ||
| */ | ||
| static final class SetsImmutableEnumSetIterableArray<T extends Enum<T>> { |
There was a problem hiding this comment.
So this one we'll likely name SetsImmutableEnumSetArraysAsList eventually; let's do already.
| * Prefer {@link Sets#immutableEnumSet(Enum, Enum[])} for enum collections to take advantage of | ||
| * the internally used {@link EnumSet}. | ||
| */ | ||
| static final class SetsImmutableEnumSet6<T extends Enum<T>> { |
There was a problem hiding this comment.
>6 variants aren't rewritten; will add comment.
| * Prefer {@link Sets#immutableEnumSet(Enum, Enum[])} for enum collections to take advantage of | ||
| * the internally used {@link EnumSet}. | ||
| */ | ||
| static final class ImmutableEnumSetVarArgs<T extends Enum<T>> { |
There was a problem hiding this comment.
| static final class ImmutableEnumSetVarArgs<T extends Enum<T>> { | |
| static final class SetsImmutableEnumSetVarArgs<T extends Enum<T>> { |
| * com.google.common.collect.ImmutableEnumSet}s. | ||
| */ | ||
| @OnlineDocumentation | ||
| final class ImmutableEnumSetRules { |
There was a problem hiding this comment.
Now that we have a new rule collection, we should move the StreamToImmutableEnumSet rule from AssortedRules.
That rule also contains a warning that applies to the new rules.
|
Looks good. No mutations were possible for these changes. |
Stephan202
changed the title
ImmutableEnumSetRules refaster rulesImmutableEnumSetRules Refaster rule collection
Stephan202
force-pushed
the
mohamedsamehsalah/immutable-enum-set
branch
from
81bf53e to
fd415f5
Compare
|
|
Looks good. No mutations were possible for these changes. |
|
Thanks @Stephan202 🙏 |
Suggested commit message